Closed stamat closed 4 months ago
Latest commit: 04265f8dd4cc3724ed4d58420e2cac0705861b45
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@langermank hey hey, when do you think this patch can be released? Just curious! 🙏 Thanks legend!
What are you trying to accomplish?
Hello there! 👋
We've got like "trillion" accessibility issues for not allowing letter spacing change by the assistive plugins on dotcom marketing pages. So I would really like to solve these and remove
!important
on letter spacing. 🙏I've created an override only for the
/marketing/type/typography.scss
file on dotcom https://github.com/github/github/pull/322450 :!important
.The only concern is that the users that might use the
mktg
styles might get impacted, but i think that Impact is minor, if not nonexiting.That's about it. Do help me merge/deploy this 🙏 ❤️
Can these changes ship as is?