primer / css

The CSS design system that powers GitHub
https://primer.style/css
MIT License
12.54k stars 1.21k forks source link

[a11y] Removing `!important` from `letter-spacing` marketing typography #2613

Closed stamat closed 4 months ago

stamat commented 4 months ago

What are you trying to accomplish?

Hello there! 👋

We've got like "trillion" accessibility issues for not allowing letter spacing change by the assistive plugins on dotcom marketing pages. So I would really like to solve these and remove !important on letter spacing. 🙏

I've created an override only for the /marketing/type/typography.scss file on dotcom https://github.com/github/github/pull/322450 :

  1. Firstly to prove that nothing will be broken - nothing is at first glance, all other utilities with letter spacign work, order of class placement seems about right to not need !important.
  2. Secondly to use as a temporary solution - but I don't really want ot use the override since it's not managable.

The only concern is that the users that might use the mktg styles might get impacted, but i think that Impact is minor, if not nonexiting.

That's about it. Do help me merge/deploy this 🙏 ❤️

Can these changes ship as is?

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: 04265f8dd4cc3724ed4d58420e2cac0705861b45

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------- | ----- | | @primer/css | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

stamat commented 4 months ago

@langermank hey hey, when do you think this patch can be released? Just curious! 🙏 Thanks legend!