search

primer / css

Primer is GitHub's design system. This is the CSS implementation
https://primer.style/css
MIT License
12.56k stars 1.21k forks source link

design-reviewers and engineer-reviewers as codeowners #2621

Closed siddharthkp closed 6 months ago

siddharthkp commented 6 months ago

What are you trying to accomplish?

In codeowners, swap css-reviewers with design-reviewers + engineer-reviewers

What approach did you choose and why?

For now, I have only added engineering-reviews on package files so that they can share the load of dependabot PRs (especially during first responder)

Can these changes ship as is?

changeset-bot[bot] commented 6 months ago

⚠️ No Changeset found

Latest commit: 78bd2d6c68d54128ef4bc0e3b1ee446dfa75dca0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

siddharthkp commented 6 months ago

@jonrohan Curious validation errors on codeowners 🤔

Unknown owner on line 1: make sure the team @primer/design-reviewers exists, is publicly visible, and has write access to the repository