primer / css

The CSS design system that powers GitHub
https://primer.style/css
MIT License
12.54k stars 1.2k forks source link

include typography utility class names in example text content #2633

Closed ktravers closed 3 months ago

ktravers commented 3 months ago

Related

https://github.com/primer/design/pull/796

What are you trying to accomplish?

Whenever I look up typography utility classes, I end up having to inspect the markup in the embedded Storybook to get the actual class name. It would be much easier if the class names were written out in the text content instead, so they could be copy/pasted directly from the page, without having to take the extra step of inspecting the page source.

This PR adds the class names to the storybook text content.

What approach did you choose and why?

I updated the storybook text content.

What should reviewers focus on?

My intention is to make this documentation easier to use. I'd appreciate feedback on whether these changes do in fact seem like an improvement. Also very open to suggestions if folks have them.

Can these changes ship as is?

Related

https://github.com/primer/design/pull/796

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: b62e15bb4eda4fac069500a9dd5cddf50112ff02

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR