primer / css

The CSS design system that powers GitHub
https://primer.style/css
MIT License
12.54k stars 1.2k forks source link

Bug fix: Removing complex padding calc on kbd #2651

Closed jonrohan closed 2 months ago

jonrohan commented 2 months ago

What are you trying to accomplish?

Before

CleanShot 2024-06-25 at 10 48 29@2x

After

CleanShot 2024-06-25 at 10 45 14@2x

What approach did you choose and why?

When transitioning from scss math to css calc, the padding was subtracting and adding too much since the size changed from pixels to rems.

Can these changes ship as is?

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: eece7de420edb33f42249bc70dfe5a83e52b24cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------- | ----- | | @primer/css | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR