search

primer / css

The CSS design system that powers GitHub
https://primer.style/css
MIT License
12.54k stars 1.2k forks source link

Include primitives.css in the main primer.css export #2657

Closed jonrohan closed 2 months ago

jonrohan commented 2 months ago

What are you trying to accomplish?

Fixes https://github.com/primer/css/issues/2648

What approach did you choose and why?

This broke because in https://github.com/primer/css/pull/2634 I converted a lot of $spacer-1 sass variables to CSS variables before. We never included the primitives in the main primer.css file before. So it was harder to notice that we were missing them. I think it makes sense to include them in the main primer.css file so that people don't have to include an extra file to get the primitives.

Can these changes ship as is?

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 6377a32a158fa2c7b61e80ba8524ee99c6a4f057

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------- | ----- | | @primer/css | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR