Open robinwhittleton opened 3 weeks ago
Latest commit: fd7782e3ce68fb65fe558f5a74fd2e66e4e607b2
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
What are you trying to accomplish?
As tables are frequently used for comparing columns of numeric data (and have the ability to be right-aligned) we should make sure that we make it as easy as possibly. Toggling tabular numbers on givens you the ability to scan columns of numbers effectively, assuming the font supports it.
Here’s an example from a recent PR without this CSS:
and with
font-variant: tabular-nums
:What approach did you choose and why?
Flipping the switch with CSS is trivial. If the font doesn’t support this functionality then this doesn’t have any effect, but is no worse than the current behaviour.
What should reviewers focus on?
First commit to Primer. Please let me know if I’m doing anything wrong, especially with the changeset which is new to me.
Can these changes ship as is?