Closed EdricChan03 closed 6 years ago
Hi all, just wanted to chime in as well to ask if https://styleguide.github.com/primer/components/pagehead/ is on the roadmap? (I noticed, too, that it's flagged as Stable in the Style Guide.) I poked around the existing branches but didn't see any mention of pagehead
on, e.g., https://github.com/primer/primer/tree/release-11.0.0. Thank you!
Hi @dmalan, the component is indeed not yet part of Primer. We could do a better job of making it clear which components live in the GitHub app source, but for now you can tell by the absence of a package and version indicator on the style guide reference: anything with a package name and version listed is part of Primer; any component without lives elsewhere, and should be considered a “private” API. :v:
Thanks, @shawnbot, helpful heuristic!
@shawnbot you comment was confusing. Could you please remove "pagehead" section from Docs to escape reproduce similar issue.
Right now I already step into that issue and misunderstand what continue in this style section. I hope that you make in sync CSS and docs.
@vit1251 I'm sorry if it's been confusing. The Style Guide is primarily for GitHub employees, but we are planning on moving all of the actual Primer docs into this repo and moving the docs for CSS that lives in github.com back into that repo to avoid confusion.
Just spent about an hour trying to figure this one out. Very confusing!
Any plans for adding this component?
I would love if this component were added too
Describe the bug
In the style guide, there's a pagehead component which gives a page a clear, separated title and optional top nav.
However, there's no such thing in the Primer CSS. (Although it seems to work in the style guide itself)
To Reproduce
Expected behavior
The pagehead component should exist.
Screenshots
Desktop (please complete the following information):
Smartphone (please complete the following information):
hlte
)Additional context EDIT: I was looking for a way to show a header in my Probot app's documentation using Primer. I stumbled upon the Pagehead component and decided to use it.