search

primer / github-syntax-theme-generator

Uses a prettylights theme object to generate syntax themes for multiple platforms
MIT License
156 stars 33 forks source link

In Atom bracket matcher does not highlight brackets on the same line #41

Closed bojand closed 7 years ago

bojand commented 7 years ago

Atom: 1.13.1x64 OS X El Capitan 10.11.6 All atom packages up to date. No custom CCS styles. Syntax theme: github-atom-light-syntax

I am not sure if this is Atom bug somehow, but it only happens for me with github-atom-light-syntax syntax theme, so I think it belongs here possibly.

The brackets on same line do not seem to be matched. Different lines do match. Notice the match (with bottom border).

atom-github-light

This happens regardless of the type of bracket.

Expected look with stock atom One Light theme:

atom-onelight

lee-dohm commented 7 years ago

It looks like the atom-text-editor .line.cursor-line style is showing up in front of the bracket-matcher decoration. When I disable the background-color on the cursor-line style, the bracket-matcher decoration shows. It appears that the cursor-line style in the default themes is transparent:

screen shot 2017-02-08 at 12 31 57 pm

whereas the one in the primer themes is opaque:

screen shot 2017-02-08 at 12 33 08 pm
bojand commented 7 years ago

Sorry to bring this up again... while the latest 0.5.0 release did technically fix this specific issue, it did make matching somewhat worse; at least aesthetically?

Atom: 1.18.0 x64 OS X El Capitan 10.12.5 All atom packages up to date. No custom CCS styles. Syntax theme: github-atom-light-syntax

bracket_issue

Not sure what's going on here, seems like the foreground text color is too light or matches the background one now. Or something.

Let me know if I should create a new issue.

simurai commented 7 years ago

I can't reproduce that slightly bluer background:

background

If you paste the following in your styles.less file, does it remove the background?

atom-text-editor .bracket-matcher,
atom-text-editor .bracket-matcher .region {
  background-color: transparent !important;
}
bojand commented 7 years ago

Hmm somehow it seems I did have custom colour for background bracket matcher in the stylesheet... I don't remember ever experimenting with it at all... but I must have... maybe it was when I was debugging the original issue and forgot to remove it or something. 

atom-text-editor.editor .bracket-matcher .region {
  background-color: #e6f5ff;
}

When I remove that it seems to work fine. Sorry my bad.