primer / github-syntax-theme-generator

Uses a prettylights theme object to generate syntax themes for multiple platforms
MIT License
156 stars 33 forks source link

Update light theme based on new GitHub color system #47

Closed jasonlong closed 7 years ago

jasonlong commented 7 years ago

This updates the light syntax to use GitHub's new color system. I didn't change any colors for any entities, only updated each to an equivalent hue in the updated palette (e.g. blues stay blue, reds stay red, etc.). The update gives everything a little more contrast to help with readability while better matching the colors that were updated on github.com recently.

Example:

screen shot 2017-04-12 at 4 20 08 pm

/cc @jonrohan As you know, we've tested this out internally and I believe we're ready to package this up to update dotcom. I'd :heart: any help with the logistics and I'm happy to do as much of the work as possible if you can point me in the right direction.

broccolini commented 7 years ago

@jasonlong Thanks for working on this and sorry this has been hanging around so long. Will test out and see if can get this published on npm and the Atom package manager.

jonrohan commented 7 years ago

This looks good any chance you want to update the dark.json theme also? I know we don't officially use it on the site, but it is used in other editors Atom, TM...

jonrohan commented 7 years ago

@jasonlong said he'll tackle the dark update in a follow-up pr