search

primer / github-syntax-theme-generator

Uses a prettylights theme object to generate syntax themes for multiple platforms
MIT License
156 stars 33 forks source link

[Bug] Broken in Atom 1.20 #57

Closed vinkla closed 7 years ago

vinkla commented 7 years ago

With all new updates in the language-php package it seems the colours in PHP doesn't match the colours on GitHub. Atom on the right and GitHub on the left:

screen shot 2017-09-19 at 21 42 47

List of syntax colours that doesn't match:

I'm running Atom version 1.20.1 with github-atom-light-syntax version 0.5.0.

Maybe @50Wliu knows more about this issue?

winstliu commented 7 years ago

Oh hey. Looks like GitHub is using php.tmbundle, not language-php. Maybe you could file an issue on github/linguist and see if they're willing to change grammar sources.

vinkla commented 7 years ago

Thanks for getting back. Is the github/linguist used in Atom at all?

winstliu commented 7 years ago

No, Atom uses its own grammar tokenizer, first-mate, based on oniguruma.

(Thanks for subtly pointing out my repo typo by the way!)

vinkla commented 7 years ago

(Thanks for subtly pointing out my repo typo by the way!)

Haha, didn’t think it was necessary to point out.

vinkla commented 7 years ago

Closing this due to inactivity.