primer / github-syntax-theme-generator

Uses a prettylights theme object to generate syntax themes for multiple platforms
MIT License
156 stars 33 forks source link

missing classes for github-syntax-light and github-syntax-dark #60

Closed dmalan closed 5 years ago

dmalan commented 6 years ago

Hi all, we noticed that https://github.com/primer/github-syntax-light/blob/master/lib/github-light.css and https://github.com/primer/github-syntax-dark/blob/master/lib/github-dark.css lack some of the classes that seem to be generated by rougify (and, equivalently, pygments). For instance, rougify highlights certain substrings of a .html file with an nt class, but absent from github-light.css and github-dark.css is a corresponding pl-nt class.

Are the CSS themes meant to be used in conjunction with an additional stylesheet? We tried, for instance, prepending each with the output of rougify style github, but that yielded an overall color scheme quite different from what we see when HTML files are highlighted on github.com itself.

Thank you!