search

primer / github-vscode-theme

GitHub's VS Code themes
https://marketplace.visualstudio.com/items?itemName=GitHub.github-vscode-theme
MIT License
1.9k stars 195 forks source link

What's the difference between github dark and dark dimmed? It seems that their background are same #190

Closed WindSoilder closed 3 years ago

dominicegginton commented 3 years ago

TLDR: GitHub Dark is an old theme, GitHub Dark Dimmed is the new theme that aims for consistency with GitHub's Primer design system.

Hi, @WindSoilder thank you for the question. Maybe we can make this clearer in the README. Here is a list of themes that are available when installing this VSCode extension:

With the release of GitHub Codespaces I believe it was important for the community and GitHub to have a constant theme across their interfaces. Hence the work to release the new themes that provide devs with an easy transition from reading and reviewing code on GitHub to working in their IDE.

We decided to keep GitHub Light & GitHub Dark as many users of the theme didn't like the change to the new light and dark themes implemented with this change. You can read about this in this discussion and pull request. This decision enables users who still want to use the old themes to update their extensions and receive bug fixes when nessasery.

WindSoilder commented 3 years ago

Thanks for your response :-D

Maybe we can make this clearer in the README

Yeah I think so, I have created a pr for this, hope that it can help