Light has recently changed some colours and now the terminal has some parts that are too dark:

[stellirin]

Light has recently changed some colours and now the terminal has some parts that are too dark:

Compared to Dimmed:

Originally posted by @stellirin in https://github.com/primer/github-vscode-theme/discussions/217#discussioncomment-1460764

[dominicegginton]

EDIT: @stellirin I have updated my comment after some investigation 🔍

Contrast issues can be found for a lot of primer/primitives ANSI colours when used as backgrounds:	Light	Dark

I don't think there is an easy fix to this as the primer team have chosen to use the default foreground colour for the terminal in this theme. The primer quite righty team have also chosen ANSI colours based upon their contrast ratio when used on the default background colour. It is near impossible for these colours to be used as backgrounds and also have acceptable contrast ratios with the foreground text.

A workaround solution: The easiest solution is to change your shells prompt to use colours that don't cause contrast issues with foreground text.

[stellirin]

1. The colours are the defaults used by the powerlevel10k plugin, pretty popular among developers (at least within my circles)
2. Other light themes don't have this issue
3. Github Light Default didn't have this issue until v5.0.0, v4.2.1 is that last 'useful' version

A small disagreement: the 'easiest' solution is to use the older version of the theme 😁

Ultimately, if updates to the theme have made text more difficult to read, then it's a failure and it should be considered a bug. I also hope the 'solution' is not like the previous solution which was to fork the theme internally and have two versions of light and dark in one package.

[broccolinisoup]

This seems like it is resolved by this commit and please see the screenshots as well. I'm closing the issue but please let us know if you have any concerns 🙂