search

primer / github-vscode-theme

GitHub's VS Code themes
https://marketplace.visualstudio.com/items?itemName=GitHub.github-vscode-theme
MIT License
1.9k stars 194 forks source link

Fix icons in high contrast themes #285

Closed simurai closed 2 years ago

simurai commented 2 years ago

This fixes https://github.com/primer/github-vscode-theme/issues/264 by improving contrast for some icons:

Before After
Screen Shot 2022-07-12 at 13 51 46 Screen Shot 2022-07-12 at 13 51 33
Screen Shot 2022-07-12 at 13 51 59 Screen Shot 2022-07-12 at 13 52 10
changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 9eece4db938df76cad3e19f5a42ee8f0c2e5b762

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------- | ----- | | github-vscode-theme | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 2 years ago
Colors changed ```diff --- base/themes/dark-colorblind.json 2022-07-12 05:15:29.336141474 +0000 +++ themes/dark-colorblind.json 2022-07-12 05:15:26.828105005 +0000 @@ -14,2 +14,4 @@ "textSeparator.foreground": "#21262d", + "icon.foreground": "#8b949e", + "keybindingLabel.foreground": "#c9d1d9", "button.background": "#1d69e0", --- base/themes/dark-default.json 2022-07-12 05:15:29.336141474 +0000 +++ themes/dark-default.json 2022-07-12 05:15:26.828105005 +0000 @@ -14,2 +14,4 @@ "textSeparator.foreground": "#21262d", + "icon.foreground": "#8b949e", + "keybindingLabel.foreground": "#c9d1d9", "button.background": "#238636", --- base/themes/dark-dimmed.json 2022-07-12 05:15:29.336141474 +0000 +++ themes/dark-dimmed.json 2022-07-12 05:15:26.828105005 +0000 @@ -14,2 +14,4 @@ "textSeparator.foreground": "#373e47", + "icon.foreground": "#768390", + "keybindingLabel.foreground": "#adbac7", "button.background": "#347d39", --- base/themes/dark-high-contrast.json 2022-07-12 05:15:29.336141474 +0000 +++ themes/dark-high-contrast.json 2022-07-12 05:15:26.828105005 +0000 @@ -14,2 +14,4 @@ "textSeparator.foreground": "#7a828e", + "icon.foreground": "#f0f3f6", + "keybindingLabel.foreground": "#f0f3f6", "button.background": "#09b43a", --- base/themes/light-colorblind.json 2022-07-12 05:15:29.336141474 +0000 +++ themes/light-colorblind.json 2022-07-12 05:15:26.828105005 +0000 @@ -14,2 +14,4 @@ "textSeparator.foreground": "#d8dee4", + "icon.foreground": "#57606a", + "keybindingLabel.foreground": "#24292f", "button.background": "#0088ff", --- base/themes/light-default.json 2022-07-12 05:15:29.336141474 +0000 +++ themes/light-default.json 2022-07-12 05:15:26.828105005 +0000 @@ -14,2 +14,4 @@ "textSeparator.foreground": "#d8dee4", + "icon.foreground": "#57606a", + "keybindingLabel.foreground": "#24292f", "button.background": "#2da44e", --- base/themes/light-high-contrast.json 2022-07-12 05:15:29.336141474 +0000 +++ themes/light-high-contrast.json 2022-07-12 05:15:26.828105005 +0000 @@ -14,2 +14,4 @@ "textSeparator.foreground": "#88929d", + "icon.foreground": "#24292f", + "keybindingLabel.foreground": "#24292f", "button.background": "#055d20", ```