primer / github-vscode-theme

GitHub's VS Code themes
https://marketplace.visualstudio.com/items?itemName=GitHub.github-vscode-theme
MIT License
1.9k stars 194 forks source link

Improve selection in High Contrast themes #294

Closed simurai closed 2 years ago

simurai commented 2 years ago

This closes https://github.com/primer/github-vscode-theme/issues/271 by making sure the background in High Contrast themes has enough contrast.

Before After
Screen Shot 2022-07-14 at 14 35 34 Screen Shot 2022-07-14 at 15 16 59
Screen Shot 2022-07-14 at 15 17 59 Screen Shot 2022-07-14 at 15 14 34
changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 5593a096d817ae7d9e7a9234ec31034d3a042cce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------- | ----- | | github-vscode-theme | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 2 years ago
Colors changed ```diff --- base/themes/dark-colorblind.json 2022-07-14 06:23:17.054858502 +0000 +++ themes/dark-colorblind.json 2022-07-14 06:23:14.430869467 +0000 @@ -118,4 +118,2 @@ "editor.linkedEditingBackground": "#58a6ff12", - "editor.inactiveSelectionBackground": "#58a6ff12", - "editor.selectionBackground": "#58a6ff33", "editor.selectionHighlightBackground": "#42a0ff40", --- base/themes/dark-default.json 2022-07-14 06:23:17.054858502 +0000 +++ themes/dark-default.json 2022-07-14 06:23:14.430869467 +0000 @@ -118,4 +118,2 @@ "editor.linkedEditingBackground": "#58a6ff12", - "editor.inactiveSelectionBackground": "#58a6ff12", - "editor.selectionBackground": "#58a6ff33", "editor.selectionHighlightBackground": "#3fb95040", --- base/themes/dark-dimmed.json 2022-07-14 06:23:17.054858502 +0000 +++ themes/dark-dimmed.json 2022-07-14 06:23:14.430869467 +0000 @@ -118,4 +118,2 @@ "editor.linkedEditingBackground": "#539bf512", - "editor.inactiveSelectionBackground": "#539bf512", - "editor.selectionBackground": "#539bf533", "editor.selectionHighlightBackground": "#57ab5a40", --- base/themes/dark-high-contrast.json 2022-07-14 06:23:17.054858502 +0000 +++ themes/dark-high-contrast.json 2022-07-14 06:23:14.430869467 +0000 @@ -119,4 +119,4 @@ "editor.linkedEditingBackground": "#71b7ff12", - "editor.inactiveSelectionBackground": "#71b7ff12", - "editor.selectionBackground": "#71b7ff33", + "editor.inactiveSelectionBackground": "#9ea7b3", + "editor.selectionBackground": "#ffffff", "editor.selectionHighlightBackground": "#26cd4d40", @@ -128,2 +128,3 @@ "editorBracketMatch.border": "#26cd4d99", + "editor.selectionForeground": "#0a0c10", "editorInlayHint.background": "#bdc4cc33", --- base/themes/light-colorblind.json 2022-07-14 06:23:17.054858502 +0000 +++ themes/light-colorblind.json 2022-07-14 06:23:14.430869467 +0000 @@ -118,4 +118,2 @@ "editor.linkedEditingBackground": "#0969da12", - "editor.inactiveSelectionBackground": "#0969da12", - "editor.selectionBackground": "#0969da33", "editor.selectionHighlightBackground": "#35adff40", --- base/themes/light-default.json 2022-07-14 06:23:17.054858502 +0000 +++ themes/light-default.json 2022-07-14 06:23:14.430869467 +0000 @@ -118,4 +118,2 @@ "editor.linkedEditingBackground": "#0969da12", - "editor.inactiveSelectionBackground": "#0969da12", - "editor.selectionBackground": "#0969da33", "editor.selectionHighlightBackground": "#4ac26b40", --- base/themes/light-high-contrast.json 2022-07-14 06:23:17.054858502 +0000 +++ themes/light-high-contrast.json 2022-07-14 06:23:14.430869467 +0000 @@ -118,4 +118,4 @@ "editor.linkedEditingBackground": "#0349b412", - "editor.inactiveSelectionBackground": "#0349b412", - "editor.selectionBackground": "#0349b433", + "editor.inactiveSelectionBackground": "#67707a", + "editor.selectionBackground": "#24292f", "editor.selectionHighlightBackground": "#26a14840", @@ -127,2 +127,3 @@ "editorBracketMatch.border": "#26a14899", + "editor.selectionForeground": "#ffffff", "editorInlayHint.background": "#acb6c033", ```