primer / github-vscode-theme

GitHub's VS Code themes
https://marketplace.visualstudio.com/items?itemName=GitHub.github-vscode-theme
MIT License
1.9k stars 194 forks source link

Improve breakpoint icon for colorblind themes #299

Closed simurai closed 2 years ago

simurai commented 2 years ago

This closes https://github.com/primer/github-vscode-theme/issues/245 by using color.danger.fg. It should have the effect that it's red in all themes, except for the color blind themes where it's "orange":

Colorblind themes Other themes
Screen Shot 2022-07-14 at 19 45 27 Screen Shot 2022-07-14 at 19 45 52
Orange Red
changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: b0f4bd9df4807e908fd46fa2ea1cb964e42358fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------- | ----- | | github-vscode-theme | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 2 years ago
Colors changed ```diff --- base/themes/dark-colorblind.json 2022-07-14 10:54:48.930663461 +0000 +++ themes/dark-colorblind.json 2022-07-14 10:54:46.562606321 +0000 @@ -149,2 +149,3 @@ "panelInput.border": "#30363d", + "debugIcon.breakpointForeground": "#c38000", "debugConsole.infoForeground": "#8b949e", --- base/themes/dark-default.json 2022-07-14 10:54:48.930663461 +0000 +++ themes/dark-default.json 2022-07-14 10:54:46.562606321 +0000 @@ -149,2 +149,3 @@ "panelInput.border": "#30363d", + "debugIcon.breakpointForeground": "#f85149", "debugConsole.infoForeground": "#8b949e", --- base/themes/dark-dimmed.json 2022-07-14 10:54:48.930663461 +0000 +++ themes/dark-dimmed.json 2022-07-14 10:54:46.562606321 +0000 @@ -149,2 +149,3 @@ "panelInput.border": "#444c56", + "debugIcon.breakpointForeground": "#e5534b", "debugConsole.infoForeground": "#768390", --- base/themes/dark-high-contrast.json 2022-07-14 10:54:48.930663461 +0000 +++ themes/dark-high-contrast.json 2022-07-14 10:54:46.562606321 +0000 @@ -153,2 +153,3 @@ "panelInput.border": "#7a828e", + "debugIcon.breakpointForeground": "#ff6a69", "debugConsole.infoForeground": "#bdc4cc", --- base/themes/light-colorblind.json 2022-07-14 10:54:48.930663461 +0000 +++ themes/light-colorblind.json 2022-07-14 10:54:46.562606321 +0000 @@ -149,2 +149,3 @@ "panelInput.border": "#d0d7de", + "debugIcon.breakpointForeground": "#ac5e00", "debugConsole.infoForeground": "#57606a", --- base/themes/light-default.json 2022-07-14 10:54:48.930663461 +0000 +++ themes/light-default.json 2022-07-14 10:54:46.562606321 +0000 @@ -149,2 +149,3 @@ "panelInput.border": "#d0d7de", + "debugIcon.breakpointForeground": "#cf222e", "debugConsole.infoForeground": "#57606a", --- base/themes/light-high-contrast.json 2022-07-14 10:54:48.930663461 +0000 +++ themes/light-high-contrast.json 2022-07-14 10:54:46.562606321 +0000 @@ -152,2 +152,3 @@ "panelInput.border": "#30363d", + "debugIcon.breakpointForeground": "#a0111f", "debugConsole.infoForeground": "#4f5760", ```