search

primer / github-vscode-theme

GitHub's VS Code themes
https://marketplace.visualstudio.com/items?itemName=GitHub.github-vscode-theme
MIT License
1.89k stars 195 forks source link

Semantic token highlighting #326

Open charconstpointer opened 2 years ago

charconstpointer commented 2 years ago

It seems like this theme does not support semantic highlighting https://code.visualstudio.com/api/language-extensions/semantic-highlight-guide

Github Theme with "gopls": { "ui.semanticTokens": true }

Screenshot 2022-09-24 at 00 51 31

Dark+ with "gopls": { "ui.semanticTokens": true }

Screenshot 2022-09-24 at 00 51 24

Dark+ with "gopls": { "ui.semanticTokens": false }

Screenshot 2022-09-24 at 00 51 08

Will this be supported in the future?

ShadiestGoat commented 1 year ago

Yes I came here for the exact same reason - %v in go strings is not highlighted!

ShadiestGoat commented 1 year ago

I believe that there is actual support for semantic highlighting to some extent actually! On GitHub Dark Default, are differences between a regular string and %v, image

It is just very low contrast

ShadiestGoat commented 1 year ago

image image

soraros commented 1 year ago

@simurai I think this issue is not closed with #337 alone.

simurai commented 1 year ago

I think this issue is not closed with https://github.com/primer/github-vscode-theme/pull/337 alone.

Ohh.. ok. Let's reopen it for further improvements.