primer / github-vscode-theme

GitHub's VS Code themes
https://marketplace.visualstudio.com/items?itemName=GitHub.github-vscode-theme
MIT License
1.89k stars 195 forks source link

Add background color to editor sticky scroll #327

Closed kennith closed 1 year ago

kennith commented 2 years ago

This PR adds background color to editorStickyScroll

Before:

image

After:

image
changeset-bot[bot] commented 2 years ago

⚠️ No Changeset found

Latest commit: 7eacd3ac0ec3dcd196d40b22eea14223ebfe5614

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

simurai commented 1 year ago

Thanks a lot for the PR, but I'm gonna close it as wontfix. The darker background does make the sticky part stand out more, but it also looks a bit weird because it doesn't match the tab and breadcrumbs anymore. Also it would compete with the selected line that looks similar.

Screen Shot 2023-01-03 at 11 02 21

If you still feel strongly about this change, you could add it to your personal settings.