[FIX] Update diff highlighting

primer / github-vscode-theme

GitHub's VS Code themes

https://marketplace.visualstudio.com/items?itemName=GitHub.github-vscode-theme

MIT License

1.89k stars 189 forks source link

[FIX] Update diff highlighting #328

Closed Mekomancer closed 1 year ago

Mekomancer commented 1 year ago

Closes #325

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: ed605f65cf463145ea904c06dfe91206b3dacd65

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ------------------- | ----- | | github-vscode-theme | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

lukasoppermann commented 1 year ago

Hey @Mekomancer I think this sadly does not work because there are a lot of possible layering problems where this color is layered on top of other things that need to be visible through the color.

I think @simurai can let us know if my assumption is correct or not.

simurai commented 1 year ago

where this color is layered on top of other things

👍 Yes, most of the backgrounds need to be semi-transparent so that underlaying layers remain visible. Things like selections or bracket/word matcher. From the VS Code docs:

The color must not be opaque so as not to hide underlying decorations.

It's a shame we can't use the colors from Primitives, but the VS Code theme is a bit an edge case in that regard.

simurai commented 1 year ago

Took another look. The current diff should already have more contrast than the screenshots in https://github.com/primer/github-vscode-theme/issues/325, but with https://github.com/primer/github-vscode-theme/pull/328/commits/1be76bb40016386dcb4e0b3fbcb6d94467203afa I increased the contrast for diff colors a bit more, but still kept it semi-transparent. Here the changes:

github.com	Before	After