search

primer / github-vscode-theme

GitHub's VS Code themes
https://marketplace.visualstudio.com/items?itemName=GitHub.github-vscode-theme
MIT License
1.89k stars 189 forks source link

Too much blue in html dark-color-blind-theme #329

Closed golam71 closed 1 year ago

golam71 commented 1 year ago

please add some yellow colors in html file html is very clittered and using blue everywhere creates a mess pls help

simurai commented 1 year ago

Mind posting some example code and a screenshot so it's easier to reproduce the issue.

golam71 commented 1 year ago

u can see in the image below just open a html file

image

my suggestion is to add some orange

simurai commented 1 year ago

What's the exact theme name you're using? Is it GitHub Dark Default?

With the following example code:

<html lang="en">
  <head>
    <title>Img Width Attribute</title>
  </head>
  <body>
    <img src="image.png" alt="Image" width="100" />
  </body>
</html>

Elements/tags should be green and matches how github.com renders the same example code.

github.com VS Code theme
Screen Shot 2023-01-17 at 15 10 18 Screen Shot 2023-01-17 at 15 10 04
golam71 commented 1 year ago

@simurai bro the theme name says it is "github-dark-color-blind"

i said i just want some other color in the colorblind theme currently if you type html in it it only has blue

golam71 commented 1 year ago

look bro using your example code github editor image

golam71 commented 1 year ago

just add a bit of orange to it its all blue hence it makes reading code very hard i know colorblinds cant see many color but they can see so add some orange or yellow

simurai commented 1 year ago

the theme name says it is "github-dark-color-blind"

Ahh.. sorry, I missed that in the title.

The colors are defined in https://primer.style/primitives/colors where green is mapped to blue. Since green is harder to see when colorblind. But best would be to not map it to another existing color otherwise there won't be a differentiation. Maybe this theme would need a custom override.

golam71 commented 1 year ago

hmm makes sense but adding a bit or orange is a good idea because all blue is like no highlight give it a thought