primer / github-vscode-theme

GitHub's VS Code themes
https://marketplace.visualstudio.com/items?itemName=GitHub.github-vscode-theme
MIT License
1.89k stars 189 forks source link

GitHub Default Light theme doesn't match actual GitHub's light theme #333

Open melyux opened 1 year ago

melyux commented 1 year ago

Maybe there's a reason, but the default light theme looks different from GitHub's theme. It's got this brown color that GitHub never uses, doesn't mark self and variable different colors, etc.

GitHub:

Screenshot 2022-11-20 at 5 30 36 PM

This theme:

Screenshot 2022-11-20 at 5 32 14 PM
kodemeister commented 1 year ago

@melyux GitHub extensively uses brown color at least in PHP sources. For instance:

https://github.com/laravel/laravel/blob/9.x/app/Http/Kernel.php

The theme defines entity.name token color as brown (actually dark orange). This works very well for PHP but not so well for Lua. C++ namespaces like std:: are also incorrectly colored in brown. I guess the theme works best for web languages, e.g., CSS, HTML, PHP, but doesn't exactly match GitHub syntax highlighting for other languages.

simurai commented 1 year ago

What language is this? I can almost reproduce the above screenshot, but not quite:

Example code

function BatteryStat:reset(withCharing, withDischaring)
  self.awake = Usage:new()
  self.sleeping = Usage:new()
end

In VS Code as .rs (Rust)

Screen Shot 2023-01-03 at 15 50 20

amirsoroush commented 1 year ago

I could reproduce and confirm that they're different. Here are Python code snippets.

Github: image

VSCode: image

Does anyone have a proper editor.tokenColorCustomizations setting to fix the difference?