primer / github-vscode-theme

GitHub's VS Code themes
https://marketplace.visualstudio.com/items?itemName=GitHub.github-vscode-theme
MIT License
1.89k stars 189 forks source link

GitHub Dark Colorblind Dimmed #334

Closed vanyauhalin closed 1 year ago

vanyauhalin commented 1 year ago

Many thanks to the GitHub team for the colorblind themes. Even though I'm not colorblind, I still prefer to use colorblind themes, as the colors are more muted, which allows me to better focus on the code. But, unfortunately, the dark theme has a very dark background, which makes the text look brighter and more defiant. Therefore, I decided to borrow black, white, gray colors from GitHub Dark Dimmed. I'm not sure if my solution is correct in terms of colorblindness, but for me, it was a great solution. You may be able to add this preset as a new theme named GitHub Dark Colorblind Dimmed.

GitHub Dark Colorblind Dimmed:

GitHub Dark Colorblind Dimmed

GitHub Dark Colorblind:

GitHub Dark Colorblind
simurai commented 1 year ago

Thanks for the feedback. At the moment there is no plan for an adding GitHub Dark Colorblind Dimmed theme as we try to mirror github.com's appearance setting.

Therefore, I decided to borrow black, white, gray colors from GitHub Dark Dimmed. I'm not sure if my solution is correct in terms of colorblindness, but for me, it was a great solution.

Yes, customizing within your VS Code settings is a great way to make these tweaks. All monochrome colors (white, gray, black) are not changed for the colorblind themes, so using the Dimmed colors should work fine. 👍