search

primer / github-vscode-theme

GitHub's VS Code themes
https://marketplace.visualstudio.com/items?itemName=GitHub.github-vscode-theme
MIT License
1.89k stars 195 forks source link

Improve minimap slider contrast #346

Closed simurai closed 1 year ago

simurai commented 1 year ago

This improves the slider contrast for the minimap. It also keeps it in sync with the editor scrollbars.

Closes https://github.com/primer/github-vscode-theme/issues/200

Screenshots

Before After
Screen Shot 2023-01-05 at 12 23 15 Screen Shot 2023-01-05 at 12 24 55
Screen Shot 2023-01-05 at 12 16 46 Screen Shot 2023-01-05 at 12 15 57

Merge checklist

Take a look at the Contribute section for more information on how test your changes locally.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 2c27f5d099dc623c5529af12ffb3809edaaa33c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------- | ----- | | github-vscode-theme | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 year ago
Colors changed ```diff --- base/themes/dark-colorblind.json 2023-01-05 03:28:08.140266681 +0000 +++ themes/dark-colorblind.json 2023-01-05 03:28:04.932188186 +0000 @@ -143,6 +143,9 @@ "scrollbar.shadow": "#484f5833", - "scrollbarSlider.background": "#6e768133", - "scrollbarSlider.hoverBackground": "#6e768145", - "scrollbarSlider.activeBackground": "#6e768187", + "scrollbarSlider.background": "#8b949e33", + "scrollbarSlider.hoverBackground": "#8b949e3d", + "scrollbarSlider.activeBackground": "#8b949e47", "editorOverviewRuler.border": "#010409", + "minimapSlider.background": "#8b949e33", + "minimapSlider.hoverBackground": "#8b949e3d", + "minimapSlider.activeBackground": "#8b949e47", "panel.background": "#010409", --- base/themes/dark-default.json 2023-01-05 03:28:08.140266681 +0000 +++ themes/dark-default.json 2023-01-05 03:28:04.932188186 +0000 @@ -143,6 +143,9 @@ "scrollbar.shadow": "#484f5833", - "scrollbarSlider.background": "#6e768133", - "scrollbarSlider.hoverBackground": "#6e768145", - "scrollbarSlider.activeBackground": "#6e768187", + "scrollbarSlider.background": "#8b949e33", + "scrollbarSlider.hoverBackground": "#8b949e3d", + "scrollbarSlider.activeBackground": "#8b949e47", "editorOverviewRuler.border": "#010409", + "minimapSlider.background": "#8b949e33", + "minimapSlider.hoverBackground": "#8b949e3d", + "minimapSlider.activeBackground": "#8b949e47", "panel.background": "#010409", --- base/themes/dark-dimmed.json 2023-01-05 03:28:08.140266681 +0000 +++ themes/dark-dimmed.json 2023-01-05 03:28:04.932188186 +0000 @@ -143,6 +143,9 @@ "scrollbar.shadow": "#545d6833", - "scrollbarSlider.background": "#636e7b33", - "scrollbarSlider.hoverBackground": "#636e7b45", - "scrollbarSlider.activeBackground": "#636e7b87", + "scrollbarSlider.background": "#76839033", + "scrollbarSlider.hoverBackground": "#7683903d", + "scrollbarSlider.activeBackground": "#76839047", "editorOverviewRuler.border": "#1c2128", + "minimapSlider.background": "#76839033", + "minimapSlider.hoverBackground": "#7683903d", + "minimapSlider.activeBackground": "#76839047", "panel.background": "#1c2128", --- base/themes/dark-high-contrast.json 2023-01-05 03:28:08.140266681 +0000 +++ themes/dark-high-contrast.json 2023-01-05 03:28:04.932188186 +0000 @@ -147,6 +147,9 @@ "scrollbar.shadow": "#7a828e33", - "scrollbarSlider.background": "#9ea7b333", - "scrollbarSlider.hoverBackground": "#9ea7b345", - "scrollbarSlider.activeBackground": "#9ea7b387", + "scrollbarSlider.background": "#bdc4cc33", + "scrollbarSlider.hoverBackground": "#bdc4cc3d", + "scrollbarSlider.activeBackground": "#bdc4cc47", "editorOverviewRuler.border": "#010409", + "minimapSlider.background": "#bdc4cc33", + "minimapSlider.hoverBackground": "#bdc4cc3d", + "minimapSlider.activeBackground": "#bdc4cc47", "panel.background": "#010409", --- base/themes/light-colorblind.json 2023-01-05 03:28:08.140266681 +0000 +++ themes/light-colorblind.json 2023-01-05 03:28:04.932188186 +0000 @@ -144,5 +144,8 @@ "scrollbarSlider.background": "#8c959f33", - "scrollbarSlider.hoverBackground": "#8c959f45", - "scrollbarSlider.activeBackground": "#8c959f87", + "scrollbarSlider.hoverBackground": "#8c959f3d", + "scrollbarSlider.activeBackground": "#8c959f47", "editorOverviewRuler.border": "#ffffff", + "minimapSlider.background": "#8c959f33", + "minimapSlider.hoverBackground": "#8c959f3d", + "minimapSlider.activeBackground": "#8c959f47", "panel.background": "#f6f8fa", --- base/themes/light-default.json 2023-01-05 03:28:08.140266681 +0000 +++ themes/light-default.json 2023-01-05 03:28:04.928188089 +0000 @@ -144,5 +144,8 @@ "scrollbarSlider.background": "#8c959f33", - "scrollbarSlider.hoverBackground": "#8c959f45", - "scrollbarSlider.activeBackground": "#8c959f87", + "scrollbarSlider.hoverBackground": "#8c959f3d", + "scrollbarSlider.activeBackground": "#8c959f47", "editorOverviewRuler.border": "#ffffff", + "minimapSlider.background": "#8c959f33", + "minimapSlider.hoverBackground": "#8c959f3d", + "minimapSlider.activeBackground": "#8c959f47", "panel.background": "#f6f8fa", --- base/themes/light-high-contrast.json 2023-01-05 03:28:08.140266681 +0000 +++ themes/light-high-contrast.json 2023-01-05 03:28:04.928188089 +0000 @@ -147,5 +147,8 @@ "scrollbarSlider.background": "#88929d33", - "scrollbarSlider.hoverBackground": "#88929d45", - "scrollbarSlider.activeBackground": "#88929d87", + "scrollbarSlider.hoverBackground": "#88929d3d", + "scrollbarSlider.activeBackground": "#88929d47", "editorOverviewRuler.border": "#ffffff", + "minimapSlider.background": "#88929d33", + "minimapSlider.hoverBackground": "#88929d3d", + "minimapSlider.activeBackground": "#88929d47", "panel.background": "#ffffff", ```