primer / github-vscode-theme

GitHub's VS Code themes
https://marketplace.visualstudio.com/items?itemName=GitHub.github-vscode-theme
MIT License
1.89k stars 195 forks source link

Remove underline from link text #347

Closed simurai closed 1 year ago

simurai commented 1 year ago

This removes the underline for the text part of links in markdown.

  [link](https://github.com)
-  ----  ------------------
  [link](https://github.com)
+        ------------------

Doing so allows the link text to be italic when the whole text block is italic. I think this is also better because only the URL part is actually clickable and should be underlined.

Closes https://github.com/primer/github-vscode-theme/issues/74

Screenshots

Before After
Screen Shot 2023-01-05 at 17 45 31 Screen Shot 2023-01-05 at 17 46 07

Merge checklist

Take a look at the Contribute section for more information on how test your changes locally.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: ed61642babfb3beb27459f52f71ff0e171ce6890

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------- | ----- | | github-vscode-theme | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 year ago
Colors changed ```diff --- base/themes/dark-colorblind.json 2023-01-05 08:56:56.229857939 +0000 +++ themes/dark-colorblind.json 2023-01-05 08:56:53.277718662 +0000 @@ -642,4 +642,3 @@ "settings": { - "foreground": "#a5d6ff", - "fontStyle": "underline" + "foreground": "#a5d6ff" } --- base/themes/dark-default.json 2023-01-05 08:56:56.229857939 +0000 +++ themes/dark-default.json 2023-01-05 08:56:53.277718662 +0000 @@ -642,4 +642,3 @@ "settings": { - "foreground": "#a5d6ff", - "fontStyle": "underline" + "foreground": "#a5d6ff" } --- base/themes/dark-dimmed.json 2023-01-05 08:56:56.229857939 +0000 +++ themes/dark-dimmed.json 2023-01-05 08:56:53.277718662 +0000 @@ -642,4 +642,3 @@ "settings": { - "foreground": "#96d0ff", - "fontStyle": "underline" + "foreground": "#96d0ff" } --- base/themes/dark-high-contrast.json 2023-01-05 08:56:56.229857939 +0000 +++ themes/dark-high-contrast.json 2023-01-05 08:56:53.277718662 +0000 @@ -646,4 +646,3 @@ "settings": { - "foreground": "#addcff", - "fontStyle": "underline" + "foreground": "#addcff" } --- base/themes/light-colorblind.json 2023-01-05 08:56:56.229857939 +0000 +++ themes/light-colorblind.json 2023-01-05 08:56:53.277718662 +0000 @@ -627,4 +627,3 @@ "settings": { - "foreground": "#0a3069", - "fontStyle": "underline" + "foreground": "#0a3069" } --- base/themes/light-default.json 2023-01-05 08:56:56.229857939 +0000 +++ themes/light-default.json 2023-01-05 08:56:53.277718662 +0000 @@ -627,4 +627,3 @@ "settings": { - "foreground": "#0a3069", - "fontStyle": "underline" + "foreground": "#0a3069" } --- base/themes/light-high-contrast.json 2023-01-05 08:56:56.229857939 +0000 +++ themes/light-high-contrast.json 2023-01-05 08:56:53.277718662 +0000 @@ -630,4 +630,3 @@ "settings": { - "foreground": "#032563", - "fontStyle": "underline" + "foreground": "#032563" } ```