primer / github-vscode-theme

GitHub's VS Code themes
https://marketplace.visualstudio.com/items?itemName=GitHub.github-vscode-theme
MIT License
1.89k stars 189 forks source link

Update the color for the active header foreground #348

Closed broccolinisoup closed 1 year ago

broccolinisoup commented 1 year ago

Updating the settings.headerForeground from fg.muted to fg.default to make it more distinguishable from the rest of the options.

Closes #199

Screenshots

Screen Shot 2023-01-06 at 10 23 08 am

Merge checklist

Take a look at the Contribute section for more information on how test your changes locally.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 67a22b109c96e65186918673cc7a091d8ea7622e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------- | ----- | | github-vscode-theme | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 year ago
Colors changed ```diff --- base/themes/dark-colorblind.json 2023-01-06 00:28:02.432180718 +0000 +++ themes/dark-colorblind.json 2023-01-06 00:27:59.940187806 +0000 @@ -250,3 +250,3 @@ "peekViewResult.background": "#0d1117", - "settings.headerForeground": "#8b949e", + "settings.headerForeground": "#c9d1d9", "settings.modifiedItemIndicator": "#bb800966", --- base/themes/dark-default.json 2023-01-06 00:28:02.432180718 +0000 +++ themes/dark-default.json 2023-01-06 00:27:59.940187806 +0000 @@ -250,3 +250,3 @@ "peekViewResult.background": "#0d1117", - "settings.headerForeground": "#8b949e", + "settings.headerForeground": "#c9d1d9", "settings.modifiedItemIndicator": "#bb800966", --- base/themes/dark-dimmed.json 2023-01-06 00:28:02.432180718 +0000 +++ themes/dark-dimmed.json 2023-01-06 00:27:59.940187806 +0000 @@ -250,3 +250,3 @@ "peekViewResult.background": "#22272e", - "settings.headerForeground": "#768390", + "settings.headerForeground": "#adbac7", "settings.modifiedItemIndicator": "#ae7c1466", --- base/themes/light-colorblind.json 2023-01-06 00:28:02.432180718 +0000 +++ themes/light-colorblind.json 2023-01-06 00:27:59.940187806 +0000 @@ -235,3 +235,3 @@ "editor.focusedStackFrameHighlightBackground": "#54aeff66", - "settings.headerForeground": "#57606a", + "settings.headerForeground": "#24292f", "settings.modifiedItemIndicator": "#d4a72c66", --- base/themes/light-default.json 2023-01-06 00:28:02.432180718 +0000 +++ themes/light-default.json 2023-01-06 00:27:59.940187806 +0000 @@ -235,3 +235,3 @@ "editor.focusedStackFrameHighlightBackground": "#4ac26b66", - "settings.headerForeground": "#57606a", + "settings.headerForeground": "#24292f", "settings.modifiedItemIndicator": "#d4a72c66", ```