primer / github-vscode-theme

GitHub's VS Code themes
https://marketplace.visualstudio.com/items?itemName=GitHub.github-vscode-theme
MIT License
1.89k stars 195 forks source link

Default white color of GitHub Dark Default became too bright #360

Open f-squirrel opened 1 year ago

f-squirrel commented 1 year ago

Description

In version 6.3.4, the default white color is significantly brighter than it used to be in 6.3.3. It applies to variable names, items in lists, etc.

Steps to reproduce

  1. Install 6.3.4
  2. View new colors

Version

v6.3.4

Theme

GitHub Dark Default

simurai commented 1 year ago

@f-squirrel Thanks for the report.

This change in 6.3.4 is intended. We recently updated github.com to have more accessible color contrast ratios. One side effect of that change is that in the Dark Default theme, text needed to be brighter and links darker to have a big enough differentiation between them.

An alternative might be to use the GitHub Dark Dimmed theme instead. It has much less contrast and should work better in low light conditions.

GitHub Dark Default GitHub Dark Dimmed
Screen Shot 2023-03-29 at 8 50 58 Screen Shot 2023-03-29 at 8 50 45
f-squirrel commented 1 year ago

@simurai , Thank you for the quick reply. Unfortunately, the dimmed theme is too "dimmed". Could you please point me to the configuration that I can change to make this white dimmed for the default theme?

ma-ta commented 1 year ago

@f-squirrel is right!

I liked to use the GitHub Dark Default theme because of its dark background and a better contrast compared to the GitHub Dark Dimmed (this theme has a too bright screen/background and it is disturbing).

But if you use a darker background the "white" text had a perfect and comfortable contrast up to v6.3.3. The higher contrast of the "white" text and dark background in v6.3.4 is too big and very uncomfortable for eyes especially at night.

Briefly the bigger contrast between the "white" text and dark background (especially if it is a larger area of white text) IS NOT ERGONOMIC since v6.3.4 and it is a BUG.

Try to use another display for testing (e.g. an OLED with a higher contrast) and you will see...

Summary:

GitHub-Themes

rozsazoltan commented 11 months ago

Based on my observation, this is unusable in version 6.3.4. The default dark theme is too bright with sharp white text, straining my eyes and making it uncomfortable to read. The dimmed theme's background is so pale that it blends with the text. In both cases, I have to strain my eyes, which I don't want to do. The plain dark theme background color perfectly matches the slightly muted white text color in version 6.3.3.

The problem still exists. I continue to live with the 6.3.3 installation.

Guide for Installing an Older Version

[!WARNING] This is just a temporary solution until the issue is fixed!

  1. Right-click on the add-on (in the extension list)
  2. Select Install another version...
  3. Select 6.3.3