search

primer / github-vscode-theme

GitHub's VS Code themes
https://marketplace.visualstudio.com/items?itemName=GitHub.github-vscode-theme
MIT License
1.89k stars 189 forks source link

Refactor getColors function to use require directly on JSON files #364

Open DeepakKumarKhatri opened 1 year ago

DeepakKumarKhatri commented 1 year ago

This issue is refred on issue #363 in which I refactored the getColors function in colors.js to use require directly on the jsonfiles for each theme's color object. The current implementation of the function declares unnecessary variables for each theme's color object, which increases complexity and can be simplified.

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: ad2ec4f1939e919d516d5792e303515d064e8e11

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR