primer / github-vscode-theme

GitHub's VS Code themes
https://marketplace.visualstudio.com/items?itemName=GitHub.github-vscode-theme
MIT License
1.89k stars 189 forks source link

Fix transparent sticky scroll background in the code peek panel #365

Closed nNoidea closed 5 months ago

nNoidea commented 1 year ago

peekViewEditorStickyScroll.background uses the color of peekViewEditor.background and is also on top of it. peekViewEditor.background is an rgba color, which means that the sticky scroll features also becomes transparent and the text becomes unreadable when another text is underneath it.

peekViewEditor.background color seems like a normal rgb (without the alpha channel) color, but that's because the peek panel pushes away all the text underneath itself. The resulting color is the mix of peekViewEditor.background rgba and peekViewResult.background rgb values.

Since the sticky scroll feature always uses the color of the background of the panel it is in, this fix will take peekViewEditor.background and peekViewResult.background and mix them together into solid color and assign that color to the peekViewEditorStickyScroll.background to fix the issue.

Closes #361

Screenshots

Please provide before/after screenshots for any visual changes Before: image After: image Before: image After: image

Merge checklist

Take a look at the Contribute section for more information on how test your changes locally.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 09d42d0bc129b9c7ddad43de5ba9c79d5ec365c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------- | ----- | | github-vscode-theme | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

nNoidea commented 11 months ago

Did I mess up the PR progress? The problem is still in the latest version.