Closed nNoidea closed 5 months ago
Latest commit: 09d42d0bc129b9c7ddad43de5ba9c79d5ec365c2
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Did I mess up the PR progress? The problem is still in the latest version.
peekViewEditorStickyScroll.background
uses the color ofpeekViewEditor.background
and is also on top of it.peekViewEditor.background
is an rgba color, which means that the sticky scroll features also becomes transparent and the text becomes unreadable when another text is underneath it.peekViewEditor.background
color seems like a normal rgb (without the alpha channel) color, but that's because the peek panel pushes away all the text underneath itself. The resulting color is the mix ofpeekViewEditor.background
rgba andpeekViewResult.background
rgb values.Since the sticky scroll feature always uses the color of the background of the panel it is in, this fix will take
peekViewEditor.background
andpeekViewResult.background
and mix them together into solid color and assign that color to thepeekViewEditorStickyScroll.background
to fix the issue.Closes #361
Screenshots
Please provide before/after screenshots for any visual changes Before: After: Before: After:
Merge checklist
GitHub Light Default
themeTake a look at the Contribute section for more information on how test your changes locally.