primer / github-vscode-theme

GitHub's VS Code themes
https://marketplace.visualstudio.com/items?itemName=GitHub.github-vscode-theme
MIT License
1.89k stars 189 forks source link

Fix syntax highlight for js/ts with export default #372

Open xeaone opened 11 months ago

xeaone commented 11 months ago

The syntax highlighting has unexpected color when using export default inline with class in js/ts.

Notice the curly brackets, semicolon, and parentheses all adopt the class name color. This color change also modifies other syntax. It seems as though that a possible solution might be to remove the scope "meta.export.default" (Dark and Light do not include this scope).

Before

image

After

image

Merge checklist

Take a look at the Contribute section for more information on how test your changes locally.

changeset-bot[bot] commented 11 months ago

⚠️ No Changeset found

Latest commit: cf35a4cc207e8c08f12ca9972bd5b54fba2cf52d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR