search

primer / github-vscode-theme

GitHub's VS Code themes
https://marketplace.visualstudio.com/items?itemName=GitHub.github-vscode-theme
MIT License
1.89k stars 195 forks source link

Invalid "symbolIcon.constantForeground" Color #375

Closed rroessler closed 3 months ago

rroessler commented 11 months ago

Description

The color for "symbolIcon.constantForeground" was not indexed, and as such would be ignored by VS-Code.

Merge checklist

changeset-bot[bot] commented 11 months ago

⚠️ No Changeset found

Latest commit: c029d84c73fc3c768d6a6b29d9cc0f43d6e99d81

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

rroessler commented 11 months ago

In looking over the outputs of the "getTheme" function, there are also various "undefined" properties as well. Should I change this pull request to instead add a filter/error handling for bad color values?