search

primer / github-vscode-theme

GitHub's VS Code themes
https://marketplace.visualstudio.com/items?itemName=GitHub.github-vscode-theme
MIT License
1.89k stars 189 forks source link

Inline code block is not readable when using `GitHub Dark High Contrast` theme #380

Open babakfp opened 7 months ago

babakfp commented 7 months ago

Description

Hi

This is the markdown preview:

image

and it is the result of this markdown content:

image

I can confirm that this happens when all extensions (other than this one) are disabled.

Steps to reproduce

Just switch to the GitHub Dark High Contrast theme and preview a markdown content in vsCode.

Version

v6.3.4

Theme

GitHub Dark High Contrast

haidoph commented 7 months ago

What type of font is used?

tks

luctowers commented 7 months ago

this is also the case for me

luctowers commented 7 months ago

Adding this to settings.json works as a hack.

"workbench.colorCustomizations": {
    "textPreformat.foreground": "#000000"
}
babakfp commented 7 months ago

What type of font is used?

tks

https://www.jetbrains.com/lp/mono/

babakfp commented 7 months ago

Adding this to settings.json works as a hack.

"workbench.colorCustomizations": {
    "textPreformat.foreground": "#000000"
}

Awesome, thank you. I changed your code to this:

"workbench.colorCustomizations": {
    "textPreformat.background": "#3d3d3d"
},

and this is the result:

image

j-w-yun commented 2 months ago

Adding this to settings.json works as a hack.

"workbench.colorCustomizations": {
    "textPreformat.foreground": "#000000"
}

Awesome, thank you. I changed your code to this:

"workbench.colorCustomizations": {
    "textPreformat.background": "#3d3d3d"
},

and this is the result:

image

Ugh, after years of squinting at these unreadable blocks I've finally found a solution. Thanks!

Aethereal-Wraith commented 1 month ago

@babakfp

Awesome, thank you. I changed your code to this:

"workbench.colorCustomizations": {
    "textPreformat.background": "#3d3d3d"
},

and this is the result:

image

Your fix looks great! I was looking on the contribution guide in the README and it asks that contributions try to stick to the colours listed in the Primer Design System. The closest colour to your suggestion of #3d3d3d on the colour sheet is #3d424d, which is called base-color-neutral-7.