search

primer / octicons-v2

[WIP] A new look for Octicons, GitHub's icon set
https://primer.style/octicons-v2
MIT License
127 stars 12 forks source link

Paper Airplane #128

Closed brianlovin closed 4 years ago

brianlovin commented 4 years ago

https://pixelcat.githubapp.com/post/ck3925gqczqqf0770l24ud74b

We're leaning in to the paper plane icon as a send button on Android - the stock one is super sharp and doesn't look good, I think we can do better!

brianlovin commented 4 years ago

Adding a "must" for this for mobile, but there's not a hard deadline

ashygee commented 4 years ago

@brianlovin I will add it to the list but what is the priority for this if there's no hard deadline?

brianlovin commented 4 years ago

We are staff shipping Android this week and public beta in Jan, so if dotcom is shipping after that then we will need to prioritize this.

colebemis commented 4 years ago
16px 24px
paper-airplane (1) paper-airplane

Here's how it looks in @brianlovin's Android mocks:

image

Here's what a filled version might look like:

image

I think I'm leaning toward the outline one for consistency with the rest of the set. What do y'all think?

colebemis commented 4 years ago

Another question: What should we name this icon? For now, I named it paper-airplane but should it have a more specific name so it's less likely to get misused? I don't think we have to decide now. It's just something to think about.

ashygee commented 4 years ago

Wrote this in Slack but recording here as well:

I agree with consistency of using the outline version over the fill version. I also think we could name the icon send.

brianlovin commented 4 years ago

Outline is fine! I think for naming we are mixing thing and action quite frequently which makes it hard to find sometimes. I'd opt for paper-airplane personally because it maps to other naming conventions like pencil (instead of edit) or x-circle-fill instead of blocked ... although we are pretty inconsistent about this.

ashygee commented 4 years ago

I think for naming we are mixing thing and action quite frequently which makes it hard to find sometimes.

@brianlovin that makes sense. We can go back through the icons as a list but I think you're right that we should be consistent on whether we name the thing vs action.

@colebemis let's call this paper-airplane for now. We can iterate later but I think being explicit about the object makes more sense since this could be used later for other instances than just send.