Icons for GitHub Insights

primer / octicons-v2

[WIP] A new look for Octicons, GitHub's icon set

https://primer.style/octicons-v2

MIT License

127 stars 12 forks source link

Icons for GitHub Insights #143

Closed cmwinters closed 4 years ago

cmwinters commented 4 years ago

Hey all! Just wanted to chime in about some icons that would be nice to have for GitHub Insights.

We're still using material icons in a few places on GitHub Insights because we don't have an equivalent Octicon.

Line chart/area chart
We may also need a scatterchart icon in the future

ashygee commented 4 years ago

@colebemis I'll make individual issues for these.

cmwinters commented 4 years ago

@ashygee I thought of another one: we need some kind of icon for sorting table columns. Right now we are using the chevron, but we usually reserve the chevron for things like dropdowns.

Screen Recording 2019-12-20 at 03 26 PM

We may end up just using arrows for these, but maybe there's room for something custom? I'm not sure. We don't really have any standards for table sorting.

edokoa commented 4 years ago

@ashygee are you working on the chart icons? I could take them.

edokoa commented 4 years ago

Added issues #169, #170, and #171

edokoa commented 4 years ago

@cmwinters Where can I see those chart switches live?

Also @colebemis @ashygee I noticed we don't have the graph icon in the project. Should we add it?

edokoa commented 4 years ago

@ashygee @colebemis @auareyou

Do we have a defined style for those items in the new style? Caret vs. Chevron vs. Arrow? Or defined use cases for each of them?

ashygee commented 4 years ago

@edokoa we did a line graph for the insights icons in #118 but I have spoke with @cmwinters and he did mention we should plan on creating other icons for chart types.

Do we have a defined style for those items in the new style? Caret vs. Chevron vs. Arrow? Or defined use cases for each of them?

We do have chevron (#94 ) and arrow icons (#93 ) but still need to write out the usage guidelines for our recommendations on when/how to use. For what @cmwinters mentioned above in reference to sorting, I believe we could still use our chevron styles but it would be good to know why a specific sorting icon would be necessary.

edokoa commented 4 years ago

I think we could talk about this with @auareyou, check https://github.com/github/design-systems/issues/737

At MSFT we had three icons: Chevrons, carets, and arrows.

I think its a discussion worth having as we found ourselves having consistency problems in the long run too. To the dropdown, accordion, sorting cases we could add the analytics / insights case where we'd have to display variation.

cmwinters commented 4 years ago

@edokoa You can see the chart switches here.

Screen Recording 2020-01-21 at 10 06 AM

Theses are still material icons for the time being.

cc @thedamianhdez since you're the design owner of GitHub Insights

edokoa commented 4 years ago

I updated the three separate issues. We have to discuss how we'll treat solid vs. line.

ashygee commented 4 years ago

@edokoa I'm going to close this now that we have the icons currently needed as 3 separate issues.

cc @TheDamianHdez