search

primer / octicons-v2

[WIP] A new look for Octicons, GitHub's icon set
https://primer.style/octicons-v2
MIT License
127 stars 12 forks source link

24px - Symlink file #274

Closed edokoa closed 1 year ago

edokoa commented 4 years ago

This will affect / depend on two things:

https://www.figma.com/file/2rjsQp42uKvzPXzLZIqOeA/Octicons-v2-Source?node-id=746%3A1717

image

ashygee commented 4 years ago

How we treat the bottom of file icons (this one makes cutting a little bit the bottom of the file more justified)

@edokoa I thought we had agreed already that the lower left corner would be where we treat file icon details the same. I think maybe I am misunderstanding the question though.

I did make an iteration that brings the arrow up and in a little more image https://www.figma.com/file/2rjsQp42uKvzPXzLZIqOeA/Octicons-v2-Source?node-id=752%3A1933

How we treat the arrow

For the 24px icons we should be using the line arrow instead of the triangle since there is space.

cc @colebemis

edokoa commented 4 years ago

I mean because @colebemis was testing making the bottom line shorter to mimic the rounded corner in other files vs. the straight line with rounded cap that matches the left vertical line. We can discuss it in the sync today.