search

primer / octicons-v2

[WIP] A new look for Octicons, GitHub's icon set
https://primer.style/octicons-v2
MIT License
127 stars 12 forks source link

briefcase #310

Closed edokoa closed 4 years ago

edokoa commented 4 years ago

image

edokoa commented 4 years ago

Some work on this icon was already made in this issue https://github.com/primer/octicons-v2/issues/161

edokoa commented 4 years ago

https://www.figma.com/file/2rjsQp42uKvzPXzLZIqOeA/Octicons-v2-Source?node-id=1109%3A3125

image

16px

image image

24px

image image

ashygee commented 4 years ago

I was getting slight toolbox vibes and was playing around with these variations.

image

@edokoa what do you think about a little more curve?

cc @colebemis

colebemis commented 4 years ago

Ooo I like the first one @ashygee ❤️

edokoa commented 4 years ago

I like them. I like the first and second most, but maybe the second gets lost in small sizes.

edokoa commented 4 years ago

What about this 24px version?

https://www.figma.com/file/2rjsQp42uKvzPXzLZIqOeA/Octicons-v2-Source?node-id=1119%3A2122

image

image

colebemis commented 4 years ago

Looks good to me 👍

colebemis commented 4 years ago

I opened a PR to add this to Octicons: https://github.com/primer/octicons/pull/434

I'll merge when I have approvals from @ashygee and @edokoa