Closed fregante closed 6 months ago
Latest commit: 5750be4b36fa947f0a0fb6ffc44ee179b7b053b2
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.
@broccolinisoup ☺️
I'm not sure what's going on with these build failures, but I assume it's because this PR was created from a fork. I just pushed a copy up to origin to see if that fixes things: https://github.com/primer/octicons/pull/1010
Merged in #1010
In my local tests, running
yarn build
inlib/octicons_node
generatesbuild/build/svg
but after this change it generatesbuild/svg
, so it should fix the issue.However the build is a bit of spaghetti between workflows, docker entrypoints.js and multiple package.json, so it's not entirely clear if further work is required (probably not)