primer / octicons

A scalable set of icons handcrafted with <3 by GitHub
https://primer.style/foundations/icons
MIT License
8.29k stars 827 forks source link

Avoid duplicate build folder in @primer/octicons #1001

Closed fregante closed 6 months ago

fregante commented 9 months ago

In my local tests, running yarn build in lib/octicons_node generates build/build/svg but after this change it generates build/svg, so it should fix the issue.

However the build is a bit of spaghetti between workflows, docker entrypoints.js and multiple package.json, so it's not entirely clear if further work is required (probably not)

changeset-bot[bot] commented 9 months ago

⚠️ No Changeset found

Latest commit: 5750be4b36fa947f0a0fb6ffc44ee179b7b053b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 6 months ago

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

fregante commented 6 months ago

@broccolinisoup ☺️

camertron commented 6 months ago

I'm not sure what's going on with these build failures, but I assume it's because this PR was created from a fork. I just pushed a copy up to origin to see if that fixes things: https://github.com/primer/octicons/pull/1010

camertron commented 6 months ago

Merged in #1010