search

primer / octicons

A scalable set of icons handcrafted with <3 by GitHub
https://primer.style/foundations/icons
MIT License
8.22k stars 829 forks source link

fix(octicons_react): remove role if aria-hidden #1007

Closed joshblack closed 4 months ago

joshblack commented 4 months ago

This is a small changes that makes role conditional on if aria-label or aria-labelledby is present. This is to avoid having both aria-hidden and role on the element at the same time.

This also updates the root package.json file so that contributors with yarn >2 don't mess with the lockfile locally

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: e98add7f4ba9bebdffc626a1148767891f23d285

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR