search

primer / octicons

A scalable set of icons handcrafted with <3 by GitHub
https://primer.style/foundations/icons
MIT License
8.29k stars 827 forks source link

feat(octicons_react): add support for ESM import #1008

Closed joshblack closed 6 months ago

joshblack commented 7 months ago

Closes https://github.com/primer/octicons/issues/1006

Update how we expose the ESM import for @primer/octicons-react by adding an mjs extension for the icon entrypoint and an mts extension for the types import.

One way to test that the imports and types are resolving correctly is to build the package and run npx publint .. The results for this package are currently visible at: https://publint.dev/@primer/octicons-react. With this change, there should be no errors, warnings, or suggestions.

changeset-bot[bot] commented 7 months ago

🦋 Changeset detected

Latest commit: 1e89330535b713dfe4be996a55f8e105a0892c6e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR