search

primer / octicons

A scalable set of icons handcrafted with <3 by GitHub
https://primer.style/foundations/icons
MIT License
8.29k stars 827 forks source link

fix(octicons_react): remove build from npm package files #1009

Closed joshblack closed 6 months ago

joshblack commented 7 months ago

Closes https://github.com/primer/octicons/issues/998

This removes build from the list of files for the npm package. These files are not accessible since we currently use the exports field so removing this should be compatible within semver (but let me know if not!)

changeset-bot[bot] commented 7 months ago

⚠️ No Changeset found

Latest commit: ca273421ecc4147fb5d92d4fe4c7e3365ec76010

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

fregante commented 6 months ago

Hmm why not just merge my PRs?

camertron commented 6 months ago

@fregante I'm not 100% sure in this case, but we usually do this because certain actions won't run from forks.

joshblack commented 6 months ago

I'm sorry about that @fregante, that's totally on me. I'd be happy to revert this one and merge in yours if you would be interested!

fregante commented 6 months ago

No problem to leave as is, I was just wondering