search

primer / octicons

A scalable set of icons handcrafted with <3 by GitHub
https://primer.style/foundations/icons
MIT License
8.29k stars 827 forks source link

fix(octicons_react): include extension in type declaration #1020

Closed joshblack closed 5 months ago

joshblack commented 5 months ago

Closes #1018

Add an explicit extension for the types to support different moduleResolution options. This also adds in a step to the CI to run arethetypeswrong to make sure that we don't regress here in the future 👀

changeset-bot[bot] commented 5 months ago

🦋 Changeset detected

Latest commit: ac146f1fbde896e506e32650821e3f6239f0367f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------- | ----- | | @primer/octicons | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

joshblack commented 5 months ago

@siddharthkp I believe so since this will be fixing the issue to what the intent was. Let me know if there is something in particular that we should be guarding against / looking for 👀