primer / octicons

A scalable set of icons handcrafted with <3 by GitHub
https://primer.style/foundations/icons
MIT License
8.28k stars 825 forks source link

Simplify contribution workflow #384

Closed colebemis closed 4 years ago

colebemis commented 4 years ago

Problem

Our current contribution workflow has a few problems:

Here's a flowchart of the current contribution workflow:

image

Solution

Let's build a Figma plugin to allow contributors to open pull requests and commit to the primer/octicons repo directly from Figma. Here's a wireframe of what the plugin could look like:

image

The interface is modeled after the GitHub's web UI editor. Here's how I'm imagining the user flow would work:

  1. Select the icon frames you want to add or update
  2. Open the Figma plugin
  3. Write a commit message (We could probably auto-populate a default commit message)
  4. Click "Open pull request"
  5. Plugin exports and optimizes the selected SVGs and creates a new branch.
  6. Plugin redirects you to github.com to open a pull request with the new branch.
  7. Write a detailed pull request description
  8. Create pull request

Here's a flowchart showing how this plugin could simplify the contribution workflow:

image

ashygee commented 4 years ago

Just adding this for extra notes on an octicons Figma plugin: https://pixelcat.githubapp.com/post/ck6mtmz2qig1i07703yzcjz28

image

colebemis commented 4 years ago

Addressed in https://github.com/primer/figma-octicons-push