The 16px `circle` icon is slightly mis-aligned

primer / octicons

A scalable set of icons handcrafted with <3 by GitHub

https://primer.style/foundations/icons

MIT License

8.27k stars 827 forks source link

The 16px `circle` icon is slightly mis-aligned #583

Closed simurai closed 3 years ago

simurai commented 3 years ago

Reported by @laserlemon in Slack

i just wanted to point out that the (new?) circle octicon doesn’t seem to actually be a perfect circle at the 16px size. see: https://primer.style/octicons/circle-16 vs https://primer.style/octicons/issue-opened-16. the top is flattened. 24px looks

I didn't really see it, but when taking a screenshot and then zooming in with "render pixels" in Sketch, it seems that the circle is slightly off center and maybe needs to be nudged a tiny bit?

Screen Shot 2021-04-05 at 22 55 19

laserlemon commented 3 years ago

It could just be how it’s rendered in primer.style but the flat spots on the top and left were clearer there:

laserlemon commented 3 years ago

Strangely, this didn't close when https://github.com/primer/octicons/pull/584 landed. I'd close it myself but I'm not allowed! 🙈