[Bug] Website icons not in sync with release tag

primer / octicons

A scalable set of icons handcrafted with <3 by GitHub

https://primer.style/foundations/icons

MIT License

8.32k stars 827 forks source link

[Bug] Website icons not in sync with release tag #738

Closed geoffreymcgill closed 2 years ago

geoffreymcgill commented 2 years ago

The v16.3.0 icons published on the website are not in sync with the v16.3.0 release tag.

For example, see the upload icon on the website:

... and here is the upload icon in the main branch:

... vs the upload icon in the v16.3.0 release tag:

ashygee commented 2 years ago

Hi @geoffreymcgill, because we are using changesets to cut releases we have PRs automatically created for our release tracking. The updated upload icon will be in 16.3.1 as seen in this PR. https://github.com/primer/octicons/pull/735

fabriciomurta commented 2 years ago

Ashygee, I think you have the website publish workflow set for every push instead of every "release publish". So once the pull request for the upload icon was merged, the new icon reflected in the website while reporting version 16.3.0.

Now that release 16.3.1 occurred, the website is up-to-date (has 16.3.1 changes and report version 16.3.1). So I guess it is pushing a "latest" version before the version number is actually switched and, when the version string is bumped (with the release) the "push" with the version changes trigger again deployment and the site stays in sync with the reported version... until next pull request is merged. :)

In other words, the way the deploy is set up now will reflect current main in the website while reporting the latest full release version string, which made us some confusion about the upload icon and version it was included in.

geoffreymcgill commented 2 years ago

The original issue will still happen and is a valid issue. Please consider re-opening.

At the time, the website was sync'd with main (the next release?) and not the latest Release tag.