search

primer / octicons

A scalable set of icons handcrafted with <3 by GitHub
https://primer.style/foundations/icons
MIT License
8.32k stars 827 forks source link

chore: update rollup config #854

Closed joshblack closed 2 years ago

joshblack commented 2 years ago

The @primer/styled-octicons step in the react job is currently failing: https://github.com/primer/octicons/actions/runs/3208168870/jobs/5243790946

This PR updates the rollup config for lib/styled_octicons to resolve presets relative to the package instead of the files. This should address the error where the babel rollup plugin is unable to find the presets/plugins that it's looking for.

changeset-bot[bot] commented 2 years ago

⚠️ No Changeset found

Latest commit: 1bfd7f3566a7bee5c03e1e5f00ef012cc880ffdd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR