search

primer / octicons

A scalable set of icons handcrafted with <3 by GitHub
https://primer.style/foundations/icons
MIT License
8.27k stars 827 forks source link

Add Goal icons #873

Closed gavinmn closed 1 year ago

gavinmn commented 1 year ago

Closes https://github.com/github/primer/issues/1445

image

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 84ce5fcb16a164768bef7b3f5d2277ca1dd5f341

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------- | ----- | | @primer/octicons | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

colebemis commented 1 year ago

Love it! 😍

Have you tried using a 0.25px corner radius on the end of the arrow for consistency with other icons?

CleanShot 2022-11-22 at 14 34 41@2x

Here's the section about that in the design guidelines: https://primer.style/octicons/guidelines/design#corners

gavinmn commented 1 year ago

@colebemis that's a great call! I had originally tried this but got a result that was much too round so I went with a 0 px radius. I just realized tho that it was because I was applying the rounding to the icon before flattening it. I just commited some new icons that should fix this inconsistency.

gavinmn commented 1 year ago

@colebemis is this good to go?