search

primer / octicons

A scalable set of icons handcrafted with <3 by GitHub
https://primer.style/foundations/icons
MIT License
8.31k stars 827 forks source link

Use parameter defaults instead of defaultProps #882

Closed manuelpuyol closed 1 year ago

manuelpuyol commented 1 year ago

React is going to deprecate defaultProps in function components: https://github.com/reactjs/rfcs/blob/createlement-rfc/text/0000-create-element-changes.md#deprecate-defaultprops-on-function-components

Instead of using defaultProps, we can rely on default parameters instead!

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 9ebb8763482f8f7ff8ed45cd145d667d716d8c70

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------- | ----- | | @primer/octicons | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

manuelpuyol commented 1 year ago

@colebemis any chance we could get this merged and released? 😄