search

primer / octicons

A scalable set of icons handcrafted with <3 by GitHub
https://primer.style/foundations/icons
MIT License
8.27k stars 827 forks source link

Upgrade to latest version of SVG Optimizer #886

Closed eliperkins closed 1 year ago

eliperkins commented 1 year ago

This includes a bug fix which prevents malformed SVGs when rendering on macOS or iOS platforms.

Closes #866

Before (in GitHub.app on iOS 16.2) After (in GitHub.app on iOS 16.2)
Simulator Screen Shot - iPhone 14 Pro - 2022-12-20 at 17 59 44 Simulator Screen Shot - iPhone 14 Pro - 2022-12-20 at 18 11 10

Note gear-16, person-fill-24 and link-16 all appearing incorrectly in the before screenshot, and then rendering correctly in the after.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 7efed67eb6d73ecfb94ea18c0d846b2e4f6430df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------- | ----- | | @primer/octicons | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

eliperkins commented 1 year ago

This is blocked by #889

eliperkins commented 1 year ago

Alright, after incorporating #889 , this should be good to go again!