primer / octicons

A scalable set of icons handcrafted with <3 by GitHub
https://primer.style/foundations/icons
MIT License
8.31k stars 827 forks source link

[Bug] up/down chevron alignment #894

Closed langermank closed 1 year ago

langermank commented 1 year ago

Closes https://github.com/github/primer/issues/1673

This PR adjusts where the SVG sits within the frame to improve horizontal alignment between these related icons.

Before

image

After

image

Concerns

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: fadb376171ef353440d9c292d0e5280d572af138

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------- | ----- | | @primer/octicons | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

gavinmn commented 1 year ago

Going to add this to the Octicons agenda for next Wednesday.

langermank commented 1 year ago

Here's a preview of how these changes will impact Primer React https://primer-3ab97043a8-13348165.drafts.github.io/storybook/?path=/story/components-iconbutton-features--chevron-test