Closed gavinmn closed 1 year ago
Latest commit: e2b94c428020bf135a19b0ab4b755abd4f54728e
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Should this be called passkey-fill
?
Should this be called
passkey-fill
?
🤔 That's a good question. It's technically a filled icon, but it's not a filled icon with an outline icon counterpart since it's made specifically to follow the passkey spec. @tallys any opinions since this is kind of half a branded icon?
We need "darkmode" versions of these as well for visibility.
Are there any code examples you can point me to on how folks use svgs in-place of icons / resolve github color theme differences?
Ex:
We don't do different colors or modifications for Octicons in dark mode as far as I know, but once these are merged and released to the library they should be able to be used the same way you're currently using Octicons. Does that work or do you need to use the SVGs earlier?
@gavinmn and @colebemis let's stick to our naming conventions and give it 'fill' title for consistency, even though there's not a counterpart. This is a bit of an edge case, but I think consistency in the library makes more sense
they should be able to be used the same way you're currently using Octicons
Ah thanks, I didn't know this. In that case this should be fine, thank you so much!
Closes https://github.com/github/primer/issues/1672
Adds the Passkey icons