primer / octicons

A scalable set of icons handcrafted with <3 by GitHub
https://primer.style/foundations/icons
MIT License
8.26k stars 830 forks source link

Add discussion state Octicons #928

Closed gavinmn closed 1 year ago

gavinmn commented 1 year ago

Closes https://github.com/github/primer/issues/1895

image

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 5e59af33c72a7c3da079669d6b05554cd5425c99

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------- | ----- | | @primer/octicons | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

gavinmn commented 1 year ago

Hearing some feedback that when looking at the icons in context (example), I think I agree with — the state details are really small. I tried more variations to make this work and think this set may be better. image

antn commented 1 year ago

I think those look great, @gavinmn! Let's go with those.

gavinmn commented 1 year ago

I think those look great, @gavinmn! Let's go with those.

Working on one more "reopen" state to add and then I'll get these out the door.

gavinmn commented 1 year ago

Here's a new full proposal for the state icons, increasing the state accessory size by incorporating them into the icon and adding a discussion-reopen icon. image

gavinmn commented 1 year ago

Shipping image We're discarding the reopen variant in favor of using no icon, or the discussion-open icon.